[gnutls-devel] libtasn1 | Fix memleaks in asn1_array2tree() (!29)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Tue Jul 23 14:43:08 CEST 2019

Tim Rühsen commented on a discussion on lib/structure.c: https://gitlab.com/gnutls/libtasn1/merge_requests/29#note_194838997

>        if (*definitions == NULL)
>  	*definitions = p;
> -      if (move == DOWN)
> +      if (move == DOWN) {
> +        if (p_last && p_last->down) {

That will happen more often, I'm sure. Is there a grep / sed rule to check that ? We could make it part of syntax-check then (custom syntax-check rule).

In the long term, moving to linux-kind style with tab indentation (and space adjustment) would be nice. Like we do at GnuTLS, Wget2 and other projects. Basically it's only us two that have to agree, right ?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/libtasn1/merge_requests/29#note_194838997
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190723/a5104c00/attachment-0001.html>

More information about the Gnutls-devel mailing list