[gnutls-devel] GnuTLS | Enhance the configuration file capabilities (!1013)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1013 was reviewed by Jakub Jelen

--
  
Jakub Jelen started a new discussion on configure.ac: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138780

> +AC_DEFINE([INI_STOP_ON_FIRST_ERROR], 1, [whether to stop on first error])
> +AC_DEFINE_UNQUOTED([INI_INLINE_COMMENT_PREFIXES], [";#"], [The comment prefixes])
> +AC_DEFINE_UNQUOTED([INI_START_COMMENT_PREFIXES], [";#"], [The comment prefixes])

The comment should say here "`The inline comment prefixes`".

--
  
Jakub Jelen started a new discussion on lib/name_val_array.h: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138781

> +/*
> + * Copyright (C) 2011-2012 Free Software Foundation, Inc.

Should this come with more recent (c)?

--
  
Jakub Jelen started a new discussion on tests/system-override-hash.c: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138783

> +/*
> + * Copyright (C) 2016 Red Hat, Inc.

2019?

--
  
Jakub Jelen started a new discussion on tests/system-override-sig-hash.sh: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138784

> +#!/bin/sh
> +
> +# Copyright (C) 2017 Nikos Mavrogiannopoulos

2019?

--
  
Jakub Jelen started a new discussion on tests/system-override-sig.c: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138785

> +
> +/* This test verifies whether a system-wide configuration which disables SHA256
> + * and SHA512 is seen from the library side.

This comment is copy&paste from the previous test file, while this test actually disables the `rsa-sha256` for certs and `rsa-sha512,rsa-sha1` for signatures.

--
  
Jakub Jelen started a new discussion on tests/system-override-sig.c: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138788

> +/*
> + * Copyright (C) 2016 Red Hat, Inc.

2019?

--
  
Jakub Jelen started a new discussion on tests/system-override-invalid.sh: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138791

> +#!/bin/sh
> +
> +# Copyright (C) 2017 Nikos Mavrogiannopoulos

2019?

--
  
Jakub Jelen started a new discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138795

> + * Returns: a constant pointer to the config file loaded, or %NULL if none
> + *
> + * Since: 3.6.8

Should this say `3.6.9`?

--
  
Jakub Jelen started a new discussion on doc/cha-config.texi: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138796

> + at cindex System-wide configuration
> +
> + at acronym{GnuTLS} 3.6.8 introduced a system-wide configuration of the library

`3.6.9`

--
  
Jakub Jelen started a new discussion on NEWS: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138798

> +
> +** API and ABI modifications:
> +No changes since last version.

Added `gnutls_get_system_config_file`

--
  
Jakub Jelen started a new discussion on tests/system-override-profiles.sh: https://gitlab.com/gnutls/gnutls/merge_requests/1013#note_180138803

> +
> +# 224 bits
> +min-verification-profile=medim

Is this typo intentional `medim`?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1013
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190611/aa53732f/attachment-0001.html>