[gnutls-devel] GnuTLS | pkcs11: ignore login error when traversing tokens (!1031)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Wed Jun 19 17:31:48 CEST 2019



New Merge Request !1031

https://gitlab.com/gnutls/gnutls/merge_requests/1031

Branches: tmp-pkcs11-login-error to master
Author:    Daiki Ueno
Assignees: 


If a token is a general access device, it is expected that login attempt to that token returns error:
https://github.com/p11-glue/p11-kit/blob/master/trust/module.c#L852
    
On the other hand, _pkcs11_traverse_tokens treats the error as fatal and stops iteration.  This behavior prevents object search without token specifier if such tokens are registered in the system.  Reported by Stanislav Zidek in
https://bugzilla.redhat.com/show_bug.cgi?id=1705478

## Checklist
 * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1031
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190619/f9f2fa92/attachment.html>


More information about the Gnutls-devel mailing list