[gnutls-devel] GnuTLS | nettle/rnd-fips: add FIPS 140-2 continuous RNG test (!1034)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1034 was reviewed by Nikos Mavrogiannopoulos

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/nettle/rnd-fips.c: https://gitlab.com/gnutls/gnutls/merge_requests/1034#note_185143935

>  #include <rnd-common.h>
>  
> +#define ENTROPY_BLOCK_SIZE SHA256_DIGEST_SIZE

Should we document here why we selected the sha2 digest size?

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/nettle/rnd-fips.c: https://gitlab.com/gnutls/gnutls/merge_requests/1034#note_185143939

>  /* Reseed a generator. */
> -static int drbg_reseed(struct drbg_aes_ctx *ctx)
> +static int drbg_reseed(struct drbg_aes_ctx *ctx,

is that function necessary to be separate after this rewrite?

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/nettle/rnd-fips.c: https://gitlab.com/gnutls/gnutls/merge_requests/1034#note_185143944

>  }
>  
> +static int get_entropy(struct fips_ctx *fctx, uint8_t *buffer, size_t length)

Would this be reliable on a multi-threaded application? It looks to me that when called in parallel values may be overwritten.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1034
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190625/1f0000f3/attachment-0001.html>