[gnutls-devel] GnuTLS | Add or clean header guards in lib/ (!954)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/954 was reviewed by Nikos Mavrogiannopoulos

--
  
Nikos Mavrogiannopoulos started a new discussion on configure.ac: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066352

>  
> -AC_DEFINE([GNUTLS_COMPAT_H], 1, [Make sure we don't use old features in code.])
> +#AC_DEFINE([GNUTLS_COMPAT_H], 1, [Make sure we don't use old features in code.])

That seems unrelated change. What's the purpose of it?

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/includes/gnutls/gnutls.h.in: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066356

>   */
>  
> -

I do not think we should change any values used by API headers. Any definitions there are part of the API

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/includes/gnutls/compat.h: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066358

>  /* Typedefs for more compatibility with older GnuTLS. */
>  
> -#ifndef _GNUTLS_COMPAT_H

Same as for gnutls.h.in

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/includes/gnutls/gnutlsxx.h: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066361

>   */
>  
> -#ifndef GNUTLSXX_H

same as for gnutls.h.in

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/includes/gnutls/pkcs11.h: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066365

>   */
>  
> -#ifndef __GNUTLS_PKCS11_H

same as for gnutls.h.in

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/includes/gnutls/self-test.h: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066370

>   */
>  
> -#ifndef __GNUTLS_SELF_H

Same as for gnutls.h.in

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/includes/gnutls/system-keys.h: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066375

>   */
>  
> -#ifndef __GNUTLS_SYSTEM_KEYS_H

same as for all exported headers

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/includes/gnutls/tpm.h: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066378

>   */
>  
> -#ifndef __GNUTLS_TPM_H

same here for exported headers

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/includes/gnutls/urls.h: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066381

>   */
>  
> -#ifndef __GNUTLS_URLS_H

same here for exported headers

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/auth/srp_passwd.h: https://gitlab.com/gnutls/gnutls/merge_requests/954#note_167066385

>   */
>  
> +#ifndef GNUTLS_LIB_AUTH_SRP_PASSWD_H

Seeing this aren't we way too verbose with that rule? Is there a reason to have the GNUTLS prefix in files which are not exposed to applications?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/954
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190506/e0c9e1cb/attachment-0001.html>