[gnutls-devel] GnuTLS | Datum.c cleanup (!1002)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Mon May 20 22:04:48 CEST 2019




Tim Rühsen commented on a discussion on lib/datum.c: https://gitlab.com/gnutls/gnutls/merge_requests/1002#note_172444707

>  		return 0;
>  	}
>  
> -	dat->data = gnutls_malloc(data_size);

I just ran across it randomly. Functions that change their output params on error are IMO bad design. I wouldn't expect that as a regular user of all kinds of APIs. In my own projects I consider such behavior as bug. Other devs do so as well as bug reports from the past show that.

NP if you disagree and want to keep it.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1002#note_172444707
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190520/55180c5e/attachment.html>


More information about the Gnutls-devel mailing list