[gnutls-devel] GnuTLS | gnutls-cli-debug: fix early break for no version supported check (!1063)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Fri Sep 6 09:51:20 CEST 2019




Nikos Mavrogiannopoulos started a new discussion on src/tests.c: https://gitlab.com/gnutls/gnutls/merge_requests/1063#note_213385134

>  	return ret;
>  }
>  
> +test_code_t test_known_protocols(gnutls_session_t session)
> +{
> +	if (tls1_2_ok == 0 && tls1_1_ok == 0 && tls1_ok == 0 &&

Maybe we don't even need the different variables for this check. If we set a single variable `known_protocol` to non-zero once one is found, we wouldn't even need to update this function when a new protocol is added. Nevertheless I'm still ok with this.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1063#note_213385134
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190906/98a4b08a/attachment-0001.html>


More information about the Gnutls-devel mailing list