[gnutls-devel] GnuTLS | GOST-CNT split, part 1 (!1072)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1072 was reviewed by Nikos Mavrogiannopoulos

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/nettle/gost/gost28147.h: https://gitlab.com/gnutls/gnutls/merge_requests/1072#note_223408949

>  
> +void
> +gost28147_kdf_cryptopro(const struct gost28147_param *param,

This doesn't seem to be used by this patch set, nor has any tests (unit or higher level).

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/nettle/gost/gostdsa.h: https://gitlab.com/gnutls/gnutls/merge_requests/1072#note_223408950

>  
> +int
> +gostdsa_vko(const struct ecc_scalar *key,

Same as the other one. It doesn't seem to be used by this patch set, nor has any tests (unit or higher level).

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/nettle/cipher.c: https://gitlab.com/gnutls/gnutls/merge_requests/1072#note_223408951

>  	   .set_decrypt_key = _gost28147_set_key_cpd,
>  	},
> +	{

Not sure it makes sense to separate the commits of lib and nettle because they are kind of interdependent for the functionality.

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/algorithms/ciphers.c: https://gitlab.com/gnutls/gnutls/merge_requests/1072#note_223408952

>  	  .explicit_iv = 16,
>  	  .cipher_iv = 16},
> +	{ .name = "GOST28147-TC26Z-CNT",

Same here about the interdependency.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1072
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190928/fad10fd0/attachment-0001.html>