[gnutls-devel] GnuTLS | gnutls_aead_cipher_decrypt: check output buffer size before writing (!1312)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Aug 17 09:03:56 CEST 2020



Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1312

Branches: tmp-cipher-check-length to master
Author:    Daiki Ueno



While the documentation of `gnutls_aead_cipher_decrypt` indicates that the inout argument `ptext_len` initially holds the size that sufficiently fits the expected output size, there was no runtime check on that.  This makes the interface robuster against misuses.

Fixes #1049.

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [x] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1312
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200817/3b6c5b21/attachment-0001.html>


More information about the Gnutls-devel mailing list