[gnutls-devel] GnuTLS | fix invalid unsigned arithmetic. (!1364)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Tue Dec 1 10:05:12 CET 2020
Daiki Ueno commented on a discussion on lib/x509/x509_dn.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1364#note_457748552
>
> /* remove spaces from the end */
> while(val->size > 0 && c_isspace(val->data[val->size-1])) {
> - if (val->size-2 > 0 && val->data[val->size-2] == '\\')
> + if (val->size > 2 && val->data[val->size-2] == '\\')
Yes, we can fix it later if it turns out to be an issue.
For now, could you please:
- amend your commit with `Signed-off-by:` following the [CONTRIBUTING.md](https://gitlab.com/gnutls/gnutls/-/blob/master/CONTRIBUTING.md#git-commits)
- increase CI timeout in your setting to ~2h
- retrigger the failed CI jobs
?
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1364#note_457748552
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20201201/687ca680/attachment-0001.html>
More information about the Gnutls-devel
mailing list