[gnutls-devel] GnuTLS | session_pack: fix leak in error path (!1185)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Sun Feb 2 16:50:46 CET 2020



Michael Catanzaro created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1185

Project:Branches: TheRealMichaelCatanzaro/gnutls:mcatanzaro/session-pack-leak to gnutls/gnutls:master
Author:    Michael Catanzaro



If the application calls gnutls_session_get_data2() at the wrong time, then _gnutls_session_pack() allocates the buffer sb and forgets to clear it.

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [x] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [x] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1185
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200202/67841522/attachment.html>


More information about the Gnutls-devel mailing list