[gnutls-devel] GnuTLS | WIP: Add option to store all stapled OCSP responses to gnutls-cli (!1189)

[Development of GNU's TLS library]

Tim Rühsen started a new discussion on src/cli.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1189#note_284125462

>  
>  		if (type == GNUTLS_X509_FMT_DER) {
> -			fwrite(oresp.data, oresp.size, 1, fp);
> +			/* on success the return value is equal to the
> +			 * number of items (third parameter) */
> +			if (fwrite(oresp.data, oresp.size, 1, fp) != 1) {
> +				fprintf(stderr, "writing to %s failed\n", path);
> +				exit(1);
> +			}
>  			continue;
>  		}
>  
>  		gnutls_datum_t t;
> -		ret = gnutls_pem_base64_encode_alloc("OCSP RESPONSE", &oresp, &t);
> +		ret = gnutls_pem_base64_encode_alloc("OCSP RESPONSE",
> +						     &oresp, &t);

Wrong alignment here (needs 2xtab as indentation, then fill up with alignment spaces).
But since the source code isn't strict about 80 columns, it's fine to not break the line at all (whatever you like better).

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1189#note_284125462
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200207/0653280e/attachment.html>