[gnutls-devel] GnuTLS | New CI runner with clang combined ubsan+asan (!1151)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos commented on a discussion on lib/hello_ext.c: https://gitlab.com/gnutls/gnutls/merge_requests/1151#note_276111418

>  	int ret;
>  	hello_ext_ctx_st ctx;
>  
> -	msg &= GNUTLS_EXT_FLAG_SET_ONLY_FLAGS_MASK;
> +	msg &= (gnutls_ext_flags_t) GNUTLS_EXT_FLAG_SET_ONLY_FLAGS_MASK;

`gnutls_ext_flags_t` is to help identifying individual values. As we go to masks it doesn't make much sense, because there is is no guarrantee they value will contain only the enumerated values (it can be an OR of them), and thus it can be confusing as one could expect an actual enumerated value, however on the debugger you'll see something unrelated. As such, in my opinion, it makes more sense to make it unsigned to remove ambiguities.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1151#note_276111418
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200123/8c5cb982/attachment.html>