[gnutls-devel] GnuTLS | New CI runner with clang ubsan+asan (!1151)

[Development of GNU's TLS library]

Tim Rühsen commented on a discussion on lib/num.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1151#note_277971900

>  {
>  	data[0] = num >> 16;
>  	data[1] = num >> 8;
> -	data[2] = num;
> +	data[2] = (uint8_t) num;

Isn't that just a matter of favor ? I think (uint8_t) makes it clearer, while & 0xff still leaves the right side as uint32_t - which might trigger another compiler warning (implicit 32bit to 8bit conversion).

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1151#note_277971900
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200128/c06928af/attachment.html>