[gnutls-devel] GnuTLS | nettle/gost: support use GOST DSA support from master branch (!1183)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Thu Jan 30 11:16:25 CET 2020




Nikos Mavrogiannopoulos started a new discussion on lib/nettle/pk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1183#note_279383515

>  	switch (curve) {
>  #if ENABLE_GOST
>  	case GNUTLS_ECC_CURVE_GOST256CPA:
> -		return nettle_get_gost_256cpa();
>  	case GNUTLS_ECC_CURVE_GOST256CPXA:
> +	case GNUTLS_ECC_CURVE_GOST256B:
> +#if HAVE_NETTLE_GET_GOST_GC256B
> +		return nettle_get_gost_gc256b();

Is the ifdef needed to distinguish between the bundled and the nettle version? If yes, wouldn't it be more clear to rename the bundled symbol to match the nettle?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1183#note_279383515
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200130/e78f9b8e/attachment-0001.html>


More information about the Gnutls-devel mailing list