[gnutls-devel] GnuTLS | nettle: check validity of (EC)DH shared secret before export (!1299)

[Development of GNU's TLS library]

Stephan Mueller commented:


For both changes, I am good.

However, we analyzed SP800-56A rev3 now to the full extent and would need to require the following checks:

- Shared secret generation: section 5.7.1.1 (FFC) and 5.7.1.2 (ECC) - this patch covers this check

- receipt of remote public key following section 5.6.2.2.2:

   * FFC:

       . if PQG are RFC3526 / RFC7919 primes, then apply (at least) the partial validation from section 5.6.2.3.2

       . otherwise perform the full validation compliant to section 5.6.2.3.1

   * ECC: perform partial validation compliant to 5.6.2.3.4


- generation of local key pair following section 5.6.2.1.3:

   * FFC:

     . perform the full validation compliant to section 5.6.2.3.1

   * ECC:

     . perform a full validation compliant to section 5.6.2.3.3

Sorry for the late note.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1299#note_377102502
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200710/fcaeec32/attachment.html>