[gnutls-devel] GnuTLS | Copy Finished packet to cb_tls_unique buffer in tls13/finished (!1293)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Sat Jun 20 19:51:23 CEST 2020
Ruslan Marchenko created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1293
Project:Branches: rufferson/gnutls:tls-unique-13 to gnutls/gnutls:master
Author: Ruslan Marchenko
This change fixes gnutls_session_channel_binding call for TLSv1.3 protocol. The handshake for this protocol is executed outside of normal flow therefore cb_tls_unique buffer is not filled with right payload.
Should close #1041
## Checklist
* [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1293
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200620/2f9de50a/attachment.html>
More information about the Gnutls-devel
mailing list