[gnutls-devel] GnuTLS | x509: drop endless loop in print_extensions (!1205)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Tue Mar 10 16:30:35 CET 2020

Nikos Mavrogiannopoulos commented on a discussion on lib/x509/output.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1205#note_302587044

>  				break;
>  			addf(str, "error: get_extension_info: %s\n",
>  			     gnutls_strerror(err));
> +			/* After addf to get error message */
> +			if (err == GNUTLS_E_ASN1_DER_ERROR)

This infinite loop construction seems to be used a lot in this file, however only in few cases it can lead to infinite loops.

There are two other identical to this one:
and `gnutls_x509_crq_get_attribute_info()`

Should we handle them similarly? (if you wouldn't like as part of this MR, I can submit another one)

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1205#note_302587044
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200310/36cc9d85/attachment-0001.html>

More information about the Gnutls-devel mailing list