[gnutls-devel] GnuTLS | improve gnutls-cli-debug testing of old SSL 3.0 servers (!1221)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Mon Mar 23 03:14:46 CET 2020
Daniel Lenski created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1221
Project:Branches: dlenski/gnutls:better_SSL3.0_tests to gnutls/gnutls:master
Author: Daniel Lenski
As far as I can tell, SSL 3.0 as described in [RFC6101](https://tools.ietf.org/html/rfc6101) *does not* require any support for TLS extensions.
This MR modifies `gnutls-cli-debug` to test servers for SSL 3.0 without extensions, and without including any newer-than-SSL 3.0 ciphersuites, before testing _with_ extensions enabled, and _with_ newer-than-SSL 3.0 ciphersuites enabled.
This prevents `gnutls-cli-debug` from incorrectly reporting a lack of SSL 3.0 support in some very old, but seemingly standards-compliant, servers. (See #958 for an example.)
# Checklist
* [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [x] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [x] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1221
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200323/f15781fc/attachment.html>
More information about the Gnutls-devel
mailing list