[gnutls-devel] GnuTLS | WIP: Compare DNs by comparing their string representations (!1223)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Tue Mar 24 15:50:40 CET 2020
Pierre Ossman (Work account) created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1223
Project:Branches: CendioOssman/gnutls:compare_dn to gnutls/gnutls:master
Author: Pierre Ossman (Work account)
A binary comparison will not work in case the contents is the same but the ASN.1 type differ (e.g. PrintableString vs UTF8String). Such variations are permitted so we need to handle them.
An attempt at fixing #553.
## Checklist
* [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1223
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200324/b8c13fcb/attachment.html>
More information about the Gnutls-devel
mailing list