[gnutls-devel] GnuTLS | Decode certificate policies OIDs (!1245)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1245 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/x509/output.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1245#note_341185632

> +			strcmp(cp_oid2str[i].oid, oid) == 0 && cp_oid2str[i].name_desc != NULL)
> +			return cp_oid2str[i].name_desc;
> +		i++;

nit: why not just use a `for` loop?

--
  
Daiki Ueno started a new discussion on lib/x509/output.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1245#note_341185633

> +	do {
> +		if ((cp_oid2str[i].oid_size == len) &&
> +			strcmp(cp_oid2str[i].oid, oid) == 0 && cp_oid2str[i].name_desc != NULL)

nit: if length check is necessary, I would use `memcmp`.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1245
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200512/b1399b0f/attachment.html>