[gnutls-devel] GnuTLS | lib: improve external file loading (!1261)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Mon May 25 17:07:58 CEST 2020




Tim Rühsen started a new discussion on lib/auth/psk_passwd.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1261#note_348465129

>  
>  	/* Open the selected password file.
>  	 */
> -	fd = fopen(cred->password_file, "r");

Did you read my comments in #985 ?

"Updating gnulib, adding fopen-gnu to boostrap.conf, adding the 'e' flag to fopen/fdopen and O_CLOEXEC to open()."

Since 'e' is proposed POSIX and understood on most systems already, we should use it for fopen.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1261#note_348465129
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200525/ab8b3a1e/attachment-0001.html>


More information about the Gnutls-devel mailing list