[gnutls-devel] GnuTLS | lib: improve external file loading (!1261)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Wed May 27 18:27:23 CEST 2020

Daiki Ueno commented on a discussion on lib/cert-cred-rawpk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1261#note_350214224

>  		ret = gnutls_pcert_import_rawpk_raw(pcert, &rawpubkey,
>  						format, key_usage, 0);
> -		_gnutls_free_datum(&rawpubkey);
> +		zeroize_key(rawpubkey.data, rawpubkey.size);

Because `_gnutls_free_key_datum` assumes that the memory is allocated using `gnutls_malloc` and friends, while `read_file` allocates it with the system `malloc`. This might not be a problem nowadays, as the custom allocator support was removed long ago, but I'm pedantic :-)

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1261#note_350214224
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200527/7d265b01/attachment-0001.html>

More information about the Gnutls-devel mailing list