[gnutls-devel] GnuTLS | WIP: AIA callback to retrieve missing chain certificates (!1262)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1262 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/cert-cred.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1262#note_350219511

>  
> +/**
> + * gnutls_trust_list_set_getissuer_function:

I'd suggest prefixing `gnutls_x509_trust_list_` as other functions in this family.

--
  
Daiki Ueno started a new discussion on lib/cert-cred.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1262#note_350219513

> + * gnutls_trust_list_set_getissuer_function:
> + * @tlist: is a #gnutls_x509_trust_list_t type.
> + * @priv: is any private data to be exchanged between the application

I'm still not sure how useful it is to have `priv` argument here. In other places, we provide `_set_ptr` functions for that purpose.

--
  
Daiki Ueno started a new discussion on lib/cert-cred.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1262#note_350219515

> +     gnutls_trust_list_getissuer_function * func)
> +{
> +    tlist->issuer_callback = func;

Use tab for indent.

--
  
Daiki Ueno started a new discussion on lib/x509/verify.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1262#note_350219518

> +			        "gnutls_x509_crt_init: %s\n",
> +			        gnutls_strerror(ret));
> +		        exit(1);

Please don't call `exit` from the library, unless it is a programming error which shouldn't happen.

--
  
Daiki Ueno started a new discussion on lib/x509/verify.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1262#note_350219520

>  
>  	if (cert_list == NULL || cert_list_length == 0)
>  		return GNUTLS_E_NO_CERTIFICATE_FOUND;

Here `list` is leaking.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1262
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200527/a9693e2e/attachment.html>