[gnutls-devel] GnuTLS | _gnutls_pkcs11_verify_crt_status: check validity against system cert (!1271)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Sun May 31 12:56:28 CEST 2020

Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1271

Branches: tmp-known-certs to master
Author:    Daiki Ueno

To verify a certificate chain, this function replaces known certificates with the ones in the system trust store if possible.

However, if it is found, the function checked the validity of the original certificate rather than the certificate found in the trust store.  That revealed a problem in a scenario that (1) a certificate is
signed by multiple issuers and (2) one of the issuers' certificate has expired and included in the input chain.

This patch makes it a little robuster by actually retrieving the certificate from the trust store and check against it.

Fixes the PKCS#11 case of #1008.

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1271
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200531/bc17e1ba/attachment.html>

More information about the Gnutls-devel mailing list