[gnutls-devel] GnuTLS | Fix non-empty session id (TLS13_APPENDIX_D4) (!1350)

[Read-only notification of GnuTLS library development activities]

Norbert Pocs commented on a discussion on lib/handshake.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1350#note_450125786

>  
>  #ifdef TLS13_APPENDIX_D4
>  		if (max_ver->tls13_sem &&
> -		    session->security_parameters.session_id_size == 0) {
> +		    session->internals.resumed_security_parameters.session_id_size == 0) {
>  
>  			/* Under TLS1.3 we generate a random session ID to make
>  			 * the TLS1.3 session look like a resumed TLS1.2 session */
> -			ret = _gnutls_generate_session_id(session->security_parameters.
> +			ret = _gnutls_generate_session_id(session->internals.resumed_security_parameters.

I remade it using a local variable.
Now the tests passes, except the `tests/tls13/prf` and `tests/tlsext-decoding`. Can you please clarify what these tests are doing? I don't understand them and don't know how to solve them.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1350#note_450125786
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20201118/662cb8ee/attachment-0001.html>