[gnutls-devel] GnuTLS | x86:add detection of instruction set on Zhaoxin CPU (!1335)

[Read-only notification of GnuTLS library development activities]

Daiki Ueno commented:


This also looks pretty nice to me; great work!

I have only a few minor comments:
- ideally the CPU support should be checked in the CI; any chance perhaps to set up a [GitLab CI runner](https://docs.gitlab.com/runner/install/) on that CPU?
- it might be good to record the benchmark result somewhere (e.g., in the commit log), with `gnutls-cli --benchmark-ciphers`
- I see a few indentation mixups; will comment on those later

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1335#note_433726859
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20201021/ac0749e5/attachment.html>