[gnutls-devel] GnuTLS | Modifies P_hash() to hash the seed and label separately for TLS1.2 (!1329)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1329 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/nettle/int/tls1-prf.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1329#note_414066853

> -	uint8_t *dst)
> +	uint8_t *dst,
> +	bool flag)

I don't get the purpose of this flag (and why you feed label only in TLS 1.2), is it really needed?

--
  
Daiki Ueno started a new discussion on lib/nettle/int/tls1-prf.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1329#note_414066857

>  	struct hmac_sha1_ctx sha1_ctx;
>  	uint8_t o1[MAX_PRF_BYTES];
>  	uint8_t cseed[MAX_SEED_SIZE];

Let's remove `cseed` entirely.

--
  
Daiki Ueno started a new discussion on tests/tls12-prf.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1329#note_414066860

>  { \
> -	char tmp[512]; \
> +	char tmp[1024]; \

Why this?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1329
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200917/111a4285/attachment.html>