[gnutls-devel] GnuTLS | tests: tls13/key_share: rewrite as single process (!1457)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1457 was reviewed by Alexander Sosedkin

--
  
Alexander Sosedkin started a new discussion on tests/tls13/key_share.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1457#note_641939725

> -
> -	gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE, x509_cred);
> +	gnutls_priority_set_direct(server, "NORMAL:+VERS-TLS1.3", NULL);

`gnutls_set_default_priority(server);`?

--
  
Alexander Sosedkin started a new discussion on tests/tls13/key_share.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1457#note_641939730

> -	global_init();
> -	memset(buffer, 0, sizeof(buffer));
> +	testname = name;

Maybe keep the `success("== test %s ==\n", testname);`?

--
  
Alexander Sosedkin started a new discussion on tests/tls13/key_share.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1457#note_641939732

>  
> -	if (gnutls_group_get(session) != exp_group)
> -		myfail("group doesn't match the expected: %s\n", gnutls_group_get_name(gnutls_group_get(session)));

The check got lost.

--
  
Alexander Sosedkin started a new discussion on tests/tls13/key_share.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1457#note_641939736

> -}
> -
> +const char *side = "";

Seems underimplemented or something.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1457
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210803/8ef64971/attachment-0001.html>