[gnutls-devel] GnuTLS | ktls: basic implementation of SW mode (!1451)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1451 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_648901961

> +								   seq_number);
> +	if (ret < 0) {
> +		return GNUTLS_E_INTERNAL_ERROR;

Why not just return `ret`?

--
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_648901974

> +	mbuffer_st *bufel;
> +
> +	if (type != GNUTLS_APPLICATION_DATA || _gnutls_record_buffer_get_size(session) <= 0)

This function is only called from `_gnutls_ktls_recv_int`, which is called with `GNUTLS_ALERT` as type; so I suspect the following code might not be exercised.

--
  
Daiki Ueno started a new discussion on lib/handshake.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_648901976

>  #include "tls13/session_ticket.h"
>  #include "locks.h"
> +#include <system/ktls.h>

nit: "system/ktls.h"

--
  
Daiki Ueno started a new discussion on lib/handshake.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_648901980

> +		ret = _gnutls_ktls_set_keys(session);
> +		if (ret < 0)
> +			return -1;

Why not return `ret`?

--
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_648901988

> +		(gnutls_cipher_get (session) != GNUTLS_CIPHER_AES_128_GCM &&
> +		gnutls_cipher_get (session) != GNUTLS_CIPHER_AES_256_GCM)) {
> +		return 0;

`GNUTLS_E_UNIMPLEMENTED_FEATURE` maybe?

--
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_648901999

> +	*/
> +
> +	if (gnutls_protocol_get_version (session) != GNUTLS_TLS1_3 ||

`GNUTLS_TLS1_2` is also supported?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210811/ddc5967f/attachment-0001.html>