[gnutls-devel] GnuTLS | x509: pin/password callback support for openssl encrypted private keys (!1459)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1459 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/x509/privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1459#note_649250669

>  		    /* use the callback if any */
>  			ret = _gnutls_retrieve_pin(&key->pin, "key:", "", 0, pin, sizeof(pin));
>  			if (ret == 0) {

I guess we could simply error out if `ret != 0`; otherwise `gnutls_x509_privkey_import_pkcs8` below would be called with the same arguments as above.

--
  
Daiki Ueno started a new discussion on lib/x509/privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1459#note_649250676

> +					/* use the callback if any */
> +					ret = _gnutls_retrieve_pin(&key->pin, "key:", "", 0, pin, sizeof(pin));
> +					if (ret == 0) {

Same issue as above.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1459
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210812/9778e352/attachment.html>