[gnutls-devel] GnuTLS | Avoid tests killing entire process groups (!1463)

[Read-only notification of GnuTLS library development activities]

Alexander Sosedkin commented on a discussion on tests/tls13/prf-early.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1463#note_663059996

>  {
>  	int status = 0;
>  
> -	kill(child, SIGTERM);
> -	wait(&status);
> +	if (child) {

That'd be the case when all terminate-instead-of-exits-in-children scenarios are caught, they aren't. I've tried to catch the most common ones (`terminate() directly inside `client()` when `client()` is called in the child process), but in the process of doing that I've also noted at least one case where child is the server and at least one case where they swap roles and both called the same function calling terminate. Thus the generic safeguard.

What would be the benefits of having an assert here?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1463#note_663059996
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210827/b350d9a4/attachment-0001.html>