[gnutls-devel] GnuTLS | configure: Remove -no_weak_links from LDFLAGS after detecting function availability (!1376)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1376 was reviewed by Martin Storsjö

--
  
Martin Storsjö commented on a discussion on configure.ac: https://gitlab.com/gnutls/gnutls/-/merge_requests/1376#note_481184927

> +  dnl weakly linked function __darwin_check_fd_set_overflow. We only
> +  dnl need it above to make sure that we don't detect functions that
> +  dnl can are linked weakly (and can end up null at runtime) unless

Thanks, fixed.

--
  
Martin Storsjö commented on a discussion on configure.ac: https://gitlab.com/gnutls/gnutls/-/merge_requests/1376#note_481184928

>      AC_MSG_CHECKING([whether the linker supports -Wl,-no_weak_imports])
> -    AC_LINK_IFELSE([AC_LANG_PROGRAM([#include <sys/select.h>], [fd_set rfds; FD_ZERO(&rfds); FD_SET(0, &rfds);])],
> +    AC_LINK_IFELSE([AC_LANG_PROGRAM([], [])],

Yeah that's also an option. If there's a lot of code before the restoration, there's a risk that we try to add something else to it, which we then end up accidentally dropping, in some cases (macos only).


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1376
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210108/679a8c57/attachment.html>