[gnutls-devel] GnuTLS | configure: Remove -no_weak_links from LDFLAGS after detecting function availability (!1376)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1376 was reviewed by Martin Storsjö

--
  
Martin Storsjö commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1376#note_481313702

Still one CI failure, unrelated to this MR
```
maint.mk: out of date copyright in doc/gnutls.texi; update it
make: *** [maint.mk:1279: sc_copyright_check] Error 1
```

--
  
Martin Storsjö commented on a discussion on configure.ac: https://gitlab.com/gnutls/gnutls/-/merge_requests/1376#note_481313704

>      AC_MSG_CHECKING([whether the linker supports -Wl,-no_weak_imports])
> -    AC_LINK_IFELSE([AC_LANG_PROGRAM([#include <sys/select.h>], [fd_set rfds; FD_ZERO(&rfds); FD_SET(0, &rfds);])],
> +    AC_LINK_IFELSE([AC_LANG_PROGRAM([], [])],

Yeah that's the potential case where this isn't ideal. One could of course make it only remove one occurrance of it (the last one) too - but as one simply can't use `-Wl,-no_weak_links` with code that uses `FD_SET` with modern Xcode at all anyway, it's probably not much of a concern, so it's probably best to just go with the simplest code, with least risk of collateral breakage.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1376
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210108/6296b9e9/attachment.html>