[gnutls-devel] GnuTLS | --enable-valgrind-tests broke in 3.7.2, can't open suppressions file, leads to valgrind not invoked (#1253)

[Read-only notification of GnuTLS library development activities]

Alexander Sosedkin created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1253



## Description of problem:
`./configure` now considers valgrind unusable, test suite proceeds not to invoke it

## Version of gnutls used:
3.7.2 / b7635d4ecd / c70941cea7

## Distributor of gnutls:
I'm building from tarball / git checkout on Fedora 34

## How reproducible:
always

## Steps to Reproduce (release tarball):
```
# clean Fedora VM
dnf builddep -y gnutls
dnf install -y git-core patch wget autogen gperf libtool valgrind valgrind-devel libev-devel
wget https://www.gnupg.org/ftp/gcrypt/gnutls/v3.7/gnutls-3.7.2.tar.xz
tar xf gnutls-*.tar.xz; rm gnutls-*.tar.xz
cd gnutls*
./configure --enable-valgrind-tests
```

## Steps to Reproduce (which I've used for git bisection):
```
# clean Fedora VM
dnf builddep -y gnutls
dnf install -y git-core patch wget autogen gperf libtool valgrind valgrind-devel libev-devel
git clone --depth=1000 https://gitlab.com/gnutls/gnutls
cd gnutls
#git checkout $commit
./bootstrap
./configure --enable-valgrind-tests
```

## Actual results (3.7.2 tarball; b7635d4ecd and several newer commits):
```
checking for valgrind... valgrind
checking for valgrind options for tests... ==10087== FATAL: can't open suppressions file "\$(srcdir)/suppressions.valgrind"
no
checking whether valgrind works on executables produced by the compiler... no
```
valgrind is subsequently not used for running the tests

## Expected results (3.7.1 tarball):
```
checking for valgrind... valgrind
checking for valgrind options for tests... -q --error-exitcode=1 --leak-check=full --track-origins=yes --gen-suppressions=all --suppressions=$(srcdir)/suppressions.valgri
nd
```
valgrind is used when running the tests

## Additional info:
* `SUBMODULE_NOFETCH=1 ./bootstrap`, which I see in gitlab CI logs, seems to alleviate the problem
* b7635d4ecd looks like it introduces the issue, or at least part of it

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1253
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210708/636778b7/attachment-0001.html>