[gnutls-devel] GnuTLS | Allow registering ciphers with higher priority (!1404)

[Read-only notification of GnuTLS library development activities]

Stephan Mueller started a new discussion on lib/accelerated/afalg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_531116324

> +	}
> +
> +	return 0;
> +}
> +
> +static int afalg_aead_decrypt(void *_ctx,
> +			      const void *nonce, size_t nonce_size,
> +			      const void *auth, size_t auth_size,
> +			      size_t tag_size,
> +			      const void *encr, size_t encr_size,
> +			      void *plain, size_t plain_size)
> +{
> +	struct kcapi_aead_ctx *ctx = _ctx;
> +	struct iovec iov[3];
> +	uint32_t iovlen = 2;
> +	uint8_t authtmp[auth_size];

I recommend changing that - VLAs are not good. E.g. use the maximum auth_size for the stack buffer.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_531116324
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210317/61dc2787/attachment.html>