[gnutls-devel] GnuTLS | WIP: Add Linux kernel AF_ALG backend (!1404)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1404 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/accelerated/afalg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_531258264

> +
> +	/*
> +	 * Older kernels require tag as input. This buffer data is unused

I wonder if this still makes sense; is there a minimum version requirement of the Kernel that libkcapi requires?

--
  
Daiki Ueno commented on a discussion on lib/accelerated/afalg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_531258267

> +	struct iovec iov[3];
> +	uint32_t iovlen = 2;
> +	uint8_t authtmp[auth_size];

Afaik the maximum of AAD for GCM is quite large; maybe we will have to use heap for that?

--
  
Daiki Ueno commented on a discussion on lib/accelerated/afalg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_531258269

> +	uint32_t iovlen = 2;
> +	uint8_t authtmp[auth_size];
> +	uint8_t tagtmp[tag_size];

Here we can use `MAX_HASH_SIZE`.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210317/533ff09b/attachment.html>