[gnutls-devel] GnuTLS | WIP: Add Linux kernel AF_ALG backend (!1404)

[Read-only notification of GnuTLS library development activities]

Stephan Mueller commented on a discussion on lib/accelerated/afalg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_531270177

> +	/*
> +	 * Set AAD: IOVECs do not support const, this buffer is guaranteed to be
> +	 * read-only
> +	 */
> +	iov[0].iov_base = (void *)auth;
> +	iov[0].iov_len = auth_size;
> +
> +	/*
> +	 * Set PT: IOVECs do not support const, this buffer is guaranteed to be
> +	 * read-only
> +	 */
> +	iov[1].iov_base = (void *)plain;
> +	iov[1].iov_len = plain_size;
> +
> +	/*
> +	 * Older kernels require tag as input. This buffer data is unused

I recommend leaving it. This "older kernel" references:

```
        uint32_t len = inlen + assoclen;

        if (!handle->flags.ge_v4_9 == true)
                len += taglen;

        return len;
```

I think it is not wise to require a minimum kernel version for GnuTLS/AF_ALG. IMHO this check is cheap, we should leave this.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_531270177
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210317/78b6c080/attachment.html>