[gnutls-devel] GnuTLS | Draft: make insecure-hash filter out ciphersuites on ->prf as well (!1479)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Oct 20 14:57:02 CEST 2021

Alexander Sosedkin created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1479

Project:Branches: asosedkin/gnutls:wip/asosedki/hash-filters-prf to gnutls/gnutls:master
Author:   Alexander Sosedkin

`insecure-hash = sha384` didn't prevent ciphersuites using GNUTLS_MAC_SHA384 as `->prf` from being considered.

This change adds a test to illustrate the issue and suggests a solution for filtering on `->prf` as well.

I'm unsure about the best way of converting macs to digests, please advise.

All kinds of feedback's welcome, from subject matter to style nuances.

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [x] Code modified for feature
 * [x] Test suite updated with functionality tests
 * [x] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1479
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211020/c4aaa4e9/attachment.html>

More information about the Gnutls-devel mailing list