[gnutls-devel] GnuTLS | make insecure-hash filter out ciphersuites on ->prf as well (!1479)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Oct 20 17:38:52 CEST 2021

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1479 was reviewed by Alexander Sosedkin

Alexander Sosedkin commented on a discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1479#note_709377516

>  	for (j=0;j<priority_cache->_cipher.num_priorities;j++) {
>  		for (z=0;z<priority_cache->_mac.num_priorities;z++) {
> +			if (priority_cache->cs.size == MAX_CIPHERSUITE_SIZE)

There's also `digest_is_insecure`, a loop from a separate compilation unit that I'm less optimistic about being optimized out. But I agree, hoisting this check hurt readability for no noticeable readability benefits, moving it down.

Alexander Sosedkin commented on a discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1479#note_709377520

>  		for (j=0;j<priority_cache->_cipher.num_priorities;j++) {
>  			for (z=0;z<priority_cache->_mac.num_priorities;z++) {
> +				if (priority_cache->cs.size == MAX_CIPHERSUITE_SIZE)

Same a above.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1479
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211020/7f111f6b/attachment-0001.html>

More information about the Gnutls-devel mailing list