[gnutls-devel] GnuTLS | fix SSSE3 SHA384 to work more than once (!1466)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Wed Sep 1 16:02:11 CEST 2021
Miroslav Lichvar created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1466
Project:Branches: mlichvar/gnutls:ssse3-sha384 to gnutls/gnutls:master
Author: Miroslav Lichvar
The output function called sha512_digest() instead of sha384_digest(), which caused the hash context to be reinitialized for SHA512 instead of SHA384 and all following digests using the hash handle were wrong.
## Checklist
* [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1466
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210901/a02bbf71/attachment-0001.html>
More information about the Gnutls-devel
mailing list