[gnutls-devel] GnuTLS | WIP: KTLS key update support (!1625)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1625 was reviewed by Daiki Ueno

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1625#note_1051007326

>  			case GNUTLS_HANDSHAKE:
>  				// ignore post-handshake messages
> +				if (*(char *)data == GNUTLS_HANDSHAKE_KEY_UPDATE) {

Do we need this check? Also remove the comment on the previous line (`ignore post-handshake messages`) which is no longer the case.

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1625#note_1051007352

> +				    gnutls_handshake_description_t htype,
> +				    const void *data, size_t data_size)
> +{

Maybe add `(void)level` to suppress compiler warning?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1625
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220804/531565dd/attachment.html>