[gnutls-devel] GnuTLS | WIP: KTLS key update support (!1625)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1625 was reviewed by Daiki Ueno

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on tests/gnutls_ktls_keyupdate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1625#note_1083540372

> +#ifdef HAVE_CONFIG_H

Please insert license header. Also I'd remove `gnutls_` prefix as it is obvious that this is a gnutls test.

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on tests/gnutls_ktls_keyupdate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1625#note_1083540391

> +#endif
> +
> +#include <config.h>

Don't need to include `<config.h>` twice?

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on tests/gnutls_ktls_keyupdate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1625#note_1083540396

> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <semaphore.h>

This header is known to be non-existent on mingw platform:
https://www.gnu.org/software/gnulib/manual/html_node/semaphore_002eh.html

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on tests/gnutls_ktls_keyupdate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1625#note_1083540404

> +}
> +
> +sem_t mutex_client;

Sorry I don't understand why this helps as this test does not create threads. To synchronize between processes, we need to use a different means, e.g., signals, pipes, etc.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1625
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220831/16f89421/attachment-0001.html>