[gnutls-devel] GnuTLS | fips: add mechanism to embed FIPS module name in the library (!1508)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Tue Jan 11 10:59:20 CET 2022
Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1508 was reviewed by Florian Weimer
Florian Weimer started a new discussion on configure.ac: https://gitlab.com/gnutls/gnutls/-/merge_requests/1508#note_806726712
> + mpz_t n;
> + mpz_init(n);])],
> + [interp=`$READELF -l conftest$EXEEXT | sed -n "$extract_interp"`])
[interp=`$READELF -lW conftest$EXEEXT | sed -n "$extract_interp"`])
`-W` produces stable output suitable for scripting. Not sure why you need to link against GMP for this check, though.
Florian Weimer started a new discussion on lib/global.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1508#note_806726718
> + }
> + fwrite(banner_footer, 1, sizeof(banner_footer)-1, stdout);
It would be slightly safer to use `write` (the system call) in this context. This is not a properly linked program, and there are likely issues around stdio initialization. And the code only works if `stdout` is line-buffered (a terminal). If the output is redirected, it won't be printed before the `_exit` system call.
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1508
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Gnutls-devel