[gnutls-devel] GnuTLS | remove autogen dependency (!1506)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1506 was reviewed by Alexander Sosedkin

--
  
Alexander Sosedkin started a new discussion on python/jsonopts.py: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809584211

> +                out.write('\t\t\t\t- enabled by default\n')
> +            max_count = option.get('max')
> +            if max_count and (max_count == 'NOLIMIT' or int(max_count) > 1):

Maybe allow only 'NOLIMIT' until it's actually enforced.

--
  
Alexander Sosedkin started a new discussion on src/gen-getopt.py: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809584216

> +                if arg_type == 'number':
> +                    switch_cases.write(
> +                        f'{INDENT*4}opts->value.{lower_opt} = atoi(optarg);\n'

`atoi` is really lax and barebones, may I suggest `strtoi`?

--
  
Alexander Sosedkin started a new discussion on src/gen-getopt.py: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809584222

> +                   f'taken by {short_opts[short_opt]}'),
> +                  file=sys.stderr)
> +            short_opt = None

Abort harder, maybe, so that we don't miss these cases?

--
  
Alexander Sosedkin started a new discussion on python/jsonopts.py: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809584232

> +    }, {
> +        'long-option': 'more-help',
> +        'short-option': '!',

`-!` doesn't seem to work in my testing

--
  
Alexander Sosedkin started a new discussion on src/cfg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809584236

> +	}
> +
> +	return buffer.length == 0 ? strdup("") : buffer.data;

Why?

--
  
Alexander Sosedkin started a new discussion on README.md: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809584237

>  * [Autoconf](https://www.gnu.org/software/autoconf/)
> -* [Autogen](https://www.gnu.org/software/autogen/) (use 5.16 or later)
> +* [Python](https://www.python.org/) (use 3.7 or later)

Why 3.7 and not 3.6?

--
  
Alexander Sosedkin started a new discussion on .gitlab-ci.yml: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809584238

>        - cache/cppcheck
>    script:
> +    - MYPYPATH=$PWD/python mypy python/*.py doc/scripts/*.py src/*.py

what installs mypy?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220113/657f3243/attachment-0001.html>