[gnutls-devel] GnuTLS | remove autogen dependency (!1506)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1506 was reviewed by Daiki Ueno

--
  
Daiki Ueno commented on a discussion on src/gen-getopt.py: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809935719

> +                   f'taken by {short_opts[short_opt]}'),
> +                  file=sys.stderr)
> +            short_opt = None

We can't simply abort as srptool has this conflict already (`-v` is used as a short option of `--passwd-conf`.

--
  
Daiki Ueno commented on a discussion on python/jsonopts.py: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809935734

> +    }, {
> +        'long-option': 'more-help',
> +        'short-option': '!',

Maybe it needs to be escaped like `-\!'? It works on my environment.

--
  
Daiki Ueno commented on a discussion on src/cfg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809935741

> +	}
> +
> +	return buffer.length == 0 ? strdup("") : buffer.data;

We use NULL as the indication of error in those functions; so need a way to represent an empty value. I've added comments to the functions.

--
  
Daiki Ueno commented on a discussion on README.md: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809935751

>  * [Autoconf](https://www.gnu.org/software/autoconf/)
> -* [Autogen](https://www.gnu.org/software/autogen/) (use 5.16 or later)
> +* [Python](https://www.python.org/) (use 3.7 or later)

Fixed.

--
  
Daiki Ueno commented on a discussion on .gitlab-ci.yml: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809935762

>        - cache/cppcheck
>    script:
> +    - MYPYPATH=$PWD/python mypy python/*.py doc/scripts/*.py src/*.py

It is manually pulled in while building the docker image:
https://gitlab.com/gnutls/build-images/-/blob/master/docker-fedora34/Dockerfile#L13

--
  
Daiki Ueno commented on a discussion on src/gen-getopt.py: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809935775

> +                if arg_type == 'number':
> +                    switch_cases.write(
> +                        f'{INDENT*4}opts->value.{lower_opt} = atoi(optarg);\n'

Yeah, switched to using `strtol`, and also added support for octal and hexadecimal values as in AutoGen.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220113/6a5d744a/attachment-0001.html>