[gnutls-devel] GnuTLS | buffer size checks in accelerated cipher implementations (!1521)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Jan 26 16:29:02 CET 2022




Alexander Sosedkin commented on a discussion on lib/accelerated/x86/aes-gcm-aead.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1521#note_822392877

>  		   	void *encr, size_t encr_size)
>  {
>  	/* proper AEAD cipher */
> -	if (encr_size < plain_size + tag_size)
> +	if (unlikely(encr_size < plain_size + tag_size))

Interesting point with the overflow, standardized on `<` and subtraction in 11ef3b9a69.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1521#note_822392877
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220126/c41bcb38/attachment.html>


More information about the Gnutls-devel mailing list