[gnutls-devel] GnuTLS | fips: provide function to manually run FIPS self-tests (!1598)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1598 was reviewed by Alexander Sosedkin

--
  <!-- Get preloaded note discussion-->
  
Alexander Sosedkin started a new discussion on lib/global.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1598#note_972158684

> +			_gnutls_audit_log(NULL, "FIPS140-2 self testing part 2 failed\n");
> +		}
>  		if (res != 2) {

can be folded into the previous if block

--
  <!-- Get preloaded note discussion-->
  
Alexander Sosedkin started a new discussion on lib/fips.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1598#note_972158706

> + */
> +int
> +gnutls_fips140_run_self_tests(void)

Should it be documented as threading-unsafe?

--
  <!-- Get preloaded note discussion-->
  
Alexander Sosedkin commented on a discussion on lib/global.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1598#note_972158714

> +		_gnutls_switch_lib_state(LIB_STATE_SELFTEST);
>  		ret = _gnutls_fips_perform_self_checks1();
> +		_gnutls_switch_lib_state(LIB_STATE_ERROR);

Also, would `_gnutls_switch_fips_state` be safer to use to prevent logic mistakes?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1598
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220606/1b0d7a10/attachment.html>