[gnutls-devel] GnuTLS | lib/system/certs.c: Add support for SSL_CERT_DIR, SSL_CERT_FILE (!1541)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1541 was reviewed by Alexander Sosedkin

--
  
Alexander Sosedkin started a new discussion on lib/system/certs.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1541#note_861590873

> +			if (d != NULL && d->d_type == DT_REG) {
> +				snprintf(path, sizeof(path),
> +					 "/data/misc/keychain/cacerts-removed/%s",

I guess you intended to use `revoked_certs_dir` here.

--
  
Alexander Sosedkin started a new discussion on lib/system/certs.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1541#note_861590880

> +		do {
> +			d = readdir(dirp);
> +			if (d != NULL && d->d_type == DT_REG) {

Why just `DT_REG`, by the way?

--
  
Alexander Sosedkin started a new discussion on lib/system/certs.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1541#note_861590886

> +	if (r == 0) {
> +		ret =
> +				gnutls_x509_trust_list_add_trust_file(list,

Something strange here with the indentation.

--
  
Alexander Sosedkin started a new discussion on lib/system/certs.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1541#note_861590895

> +
> +	if (r == 0) {
> +		const char *ssl_cert_dir = getenv("SSL_CERT_DIR");

I guess @dueno's [concern about getenv thread safety](https://gitlab.com/gnutls/gnutls/-/issues/1279#note_706682807) applies.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1541
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220303/fa325b24/attachment-0001.html>