[gnutls-devel] GnuTLS | configure description for brotli/zstd is wrong (#1342)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Fri Mar 18 06:32:26 CET 2022



Sam James created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1342



>From `./configure --help`:
```
[...]
  --without-brotli        disable brotli compression support
  --without-zstd          disable zstd compression support
[...]
```

But `./configure --without-brotli --without-zstd` yields:
```
configure: WARNING: unrecognized options: --without-brotli, --without-zstd
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
[...]
```

In `configure.ac`, these options are defined as:
```
AC_ARG_WITH(libbrotli,
	    AS_HELP_STRING([--without-brotli], [disable brotli compression support]),
	    ac_brotli=$withval, ac_brotli=yes)
[...]
AC_ARG_WITH(libzstd,
	    AS_HELP_STRING([--without-zstd], [disable zstd compression support]),
	    ac_zstd=$withval, ac_zstd=yes)
[...]
```

The first argument of `AC_ARG_WITH` corresponds to the `--{with,without}-*` argument, so it all needs to be consistently `libbrotli` (etc) or `brotli` (etc).

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1342
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220318/8b3d79f6/attachment.html>


More information about the Gnutls-devel mailing list